Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add *.thrift to ignorePatterns #113

Closed
wants to merge 1 commit into from

Conversation

zanminkian
Copy link
Contributor

Let's say developer using lint-staged to lint the code before git commit. And the .lintstagedrc file looks like this:

{"*": "eslint --fix"}

It will cause error if developer is going to commit thrift file.

If not accept this PR:

  1. create a standard thrift file xxx.thrift
  2. npx eslint xxx.thrift
  3. it will throw an error on the console.

After accept this PR:

  1. create a standard thrift file xxx.thrift
  2. npx eslint xxx.thrift
  3. print a warn warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override on the console

@antfu
Copy link
Owner

antfu commented Sep 5, 2022

I am not sure. If you don't have the lint for that file, you should exclude it from your lint-stage. Otherwise we might need to exclude all the non-js files which I think it's not scalable. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants