Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low contrast for certan sidebar folders on vitesse black #21

Closed
5 tasks done
ElasticBottle opened this issue Mar 7, 2023 · 2 comments
Closed
5 tasks done

Low contrast for certan sidebar folders on vitesse black #21

ElasticBottle opened this issue Mar 7, 2023 · 2 comments

Comments

@ElasticBottle
Copy link

Describe the bug

image

Not quite sure why, but certain folders have this really low contrast text color making things hard to read and I have not manage to find the right override to update the colors 馃槩

Reproduction

instal vitesse black and note the side bar options

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
    Memory: 3.62 GB / 7.60 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.15.1/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@ElasticBottle ElasticBottle changed the title Low contract for certan sidebar folders on vitesse black Low contrast for certan sidebar folders on vitesse black Mar 7, 2023
@ghsgz
Copy link

ghsgz commented Mar 11, 2023

You can customize it in settings.json like this:

"workbench.colorCustomizations": {
    "[Vitesse Dark]": {
        "list.activeSelectionBackground": "#fff",
        "list.inactiveSelectionBackground": "#fff",
    },
}

To see all related items about list/tree items style, you can checkout these two links:

@ElasticBottle
Copy link
Author

ElasticBottle commented Mar 12, 2023

@ghsgz thanks so much for the speedy response. Tried both settings out, but I am, still see the same thing.
One thing I'm noticing is that this is specifically for the folder that are included in the gitignore.

Is there anything extra being done there to override the list styling?

Edit: Dug around more and found the much needed setting to override, thanks for pointing me in the right directions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants