change number_with_precision to not return negative zeros

anthonycrumley · Mar 27, 2012 · 7051a23 · 7051a23
1 parent ded74df
commit 7051a23
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/actionpack/lib/action_view/helpers/number_helper.rb b/actionpack/lib/action_view/helpers/number_helper.rb
@@ -292,6 +292,7 @@ def number_with_precision(number, options = {})
           precision = precision > 0 ? precision : 0  #don't let it be negative
         else
           rounded_number = BigDecimal.new(number.to_s).round(precision).to_f
+          rounded_number = rounded_number.zero? ? rounded_number.abs : rounded_number #prevent showing negative zeros
         end
         formatted_number = number_with_delimiter("%01.#{precision}f" % rounded_number, options)
         if strip_insignificant_zeros

diff --git a/actionpack/test/template/number_helper_test.rb b/actionpack/test/template/number_helper_test.rb
@@ -96,6 +96,7 @@ def test_number_with_precision
     assert_equal("0.001", number_with_precision(0.00111, :precision => 3))
     assert_equal("10.00", number_with_precision(9.995, :precision => 2))
     assert_equal("11.00", number_with_precision(10.995, :precision => 2))
+    assert_equal("0.00", number_with_precision(-0.001, :precision => 2))
   end
 
   def test_number_with_precision_with_custom_delimiter_and_separator