Improving setup routes comments #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpicaza
approved these changes
Jan 19, 2021
kpicaza
requested changes
Jan 19, 2021
| * $app->post('/album', [App\Handler\AlbumCreateHandler::class], 'album.create'); | ||
| * $app->put('/album/:id', [App\Handler\AlbumUpdateHandler::class], 'album.put'); | ||
| * $app->patch('/album/:id', [App\Handler\AlbumUpdateHandler::class], 'album.patch'); | ||
| * $app->delete('/album/:id', [App\Handler\AlbumDeleteHandler::class], 'album.delete'); |
There was a problem hiding this comment.
@peter279k Sorry for requesting a change after approval, with that we talk on antidot-framework/antidot-framework#30, I prefer to remove the next lines until it is implemented as you suggested.
*
* Or with multiple request methods:
*
* $app->route('/contact', [App\Handler\ContactHandler::class], ['GET', 'POST', ...], 'contact');
peter279k
force-pushed
the
fix_route_comments
branch
from
15ed7de
to
76b7243
Compare
kpicaza
reviewed
Jan 19, 2021
router/routes.php
Outdated
| * | ||
| * Or with multiple request methods: | ||
| * | ||
| * $app->route('/contact', App\Handler\ContactHandler::class, ['GET', 'POST', ...], 'contact'); | ||
| * $app->route('/contact', [App\Handler\ContactHandler::class], ['GET', 'POST', ...], 'contact'); |
There was a problem hiding this comment.
@peter279k My apologies, if you want I can make myself, I want to mean to delete this last comment block as in https://github.com/antidot-framework/reactive-antidot-starter/pull/12/files
peter279k
force-pushed
the
fix_route_comments
branch
from
76b7243
to
7f3cae1
Compare
kpicaza
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log