Skip to content

Commit

Permalink
Remove some unused stuff.
Browse files Browse the repository at this point in the history
* swank-ccl.lisp (openmcl-set-debug-switches)
(*interesting-internal-frames*)
(interesting-frame-p): Unused. Deleted.
  • Loading branch information
Helmut Eller committed Mar 5, 2010
1 parent 5e367f6 commit 14f9799
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 43 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2010-03-05 Helmut Eller <heller@common-lisp.net>

Remove some unused stuff.

* swank-ccl.lisp (openmcl-set-debug-switches)
(*interesting-internal-frames*)
(interesting-frame-p): Unused. Deleted.

2010-03-05 Helmut Eller <heller@common-lisp.net>

* swank-ccl.lisp: Indentation fixes.
Expand Down
49 changes: 6 additions & 43 deletions swank-ccl.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -300,16 +300,6 @@

;;; Debugging

(defun openmcl-set-debug-switches ()
(setq ccl:*fasl-save-definitions* nil)
(setq ccl:*fasl-save-doc-strings* t)
(setq ccl:*fasl-save-local-symbols* t)
(setq ccl:*save-arglist-info* t)
(setq ccl:*save-definitions* nil)
(setq ccl:*save-doc-strings* t)
(setq ccl:*save-local-symbols* t)
(ccl:start-xref))

(defimplementation call-with-debugging-environment (debugger-loop-fn)
(let* (;;(*debugger-hook* nil)
;; don't let error while printing error take us down
Expand All @@ -320,12 +310,12 @@
;; thread not selected by the user, so don't use thread-local vars
;; such as *emacs-connection*.
(defun find-repl-thread ()
(let* ((conn (funcall (swank-sym default-connection))))
(let* ((*break-on-signals* nil)
(conn (funcall (swank-sym default-connection))))
(and conn
(let ((*break-on-signals* nil))
(ignore-errors ;; this errors if no repl-thread
(funcall (swank-sym repl-thread) conn))))))

(ignore-errors ;; this errors if no repl-thread
(funcall (swank-sym repl-thread) conn)))))

(defimplementation call-with-debugger-hook (hook fun)
(let ((*debugger-hook* hook)
(ccl:*break-hook* hook)
Expand All @@ -347,34 +337,7 @@
(ccl:map-call-frames function
:origin ccl:*top-error-frame*
:start-frame-number start-frame-number
:count (- end-frame-number start-frame-number)
:test (and (not t) ;(not (symbol-value (swank-sym *sldb-show-internal-frames*)))
'interesting-frame-p))))

;; Exceptions
(defvar *interesting-internal-frames* ())

(defun interesting-frame-p (p context)
;; A frame is interesting if it has at least one external symbol in its name.
(labels ((internal (obj)
;; For a symbol, return true if the symbol is internal, i.e. not
;; declared to be external. For a cons or list, everything
;; must be internal. For a method, the name must be internal.
;; Nothing else is internal.
(typecase obj
(cons (and (internal (car obj)) (internal (cdr obj))))
(symbol (and (eq (symbol-package obj) (find-package :ccl))
(eq :internal (nth-value 1 (find-symbol (symbol-name obj) :ccl)))
(not (member obj *interesting-internal-frames*))))
(method (internal (ccl:method-name obj)))
(t nil))))
(let* ((lfun (ccl:frame-function p context))
(internal-frame-p (internal (ccl:function-name lfun))))
#+debug (format t "~S is ~@[not ~]internal~%"
(ccl:function-name lfun)
(not internal-frame-p))
(not internal-frame-p))))

:count (- end-frame-number start-frame-number))))

(defimplementation compute-backtrace (start-frame-number end-frame-number)
(let (result)
Expand Down

0 comments on commit 14f9799

Please sign in to comment.