Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mac os build #11

Merged
merged 1 commit into from
Nov 13, 2019
Merged

fix mac os build #11

merged 1 commit into from
Nov 13, 2019

Conversation

houqp
Copy link
Contributor

@houqp houqp commented Nov 12, 2019

_IO_FILE doesn't exist in Mac OS.

@ccouzens
Copy link
Collaborator

Thank you. I'll review on a Mac, and merge and release a new version at lunch (about 5 hours time)

@ccouzens
Copy link
Collaborator

Hi @houqp,

Did you consider using a glob import?

use leptonica_sys::*;

This way _IO_FILE is imported if it's there, and not if it isn't there. And if the headers ever change on Linux or Mac we won't be affected.

@houqp
fix mac os build
ba945f0 
_IO_FILE doesn't exist in OS X
@houqp
Copy link
Contributor Author

houqp commented Nov 13, 2019

Good idea, I have updated the PR.

@ccouzens ccouzens merged commit 7a711cc into antimatter15:master Nov 13, 2019
@ccouzens
Copy link
Collaborator

Thank you @houqp

I've published 0.4.1 with your change https://crates.io/crates/tesseract-sys/0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@houqp @ccouzens