Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server not sending CSS and images #9

Closed
KevinGage opened this issue Jul 22, 2015 · 5 comments
Closed

Server not sending CSS and images #9

KevinGage opened this issue Jul 22, 2015 · 5 comments

Comments

@KevinGage
Copy link
Collaborator

@mikegomezg @antimeme @amurray22 @jorgelr617 @JohnnyRobotic
I am working on a client to demo for saturday. I've been testing my client by just opening it locally with firefox. I just tried accessing my client by browsing to it on the server but it returned without the style sheet and images. I think this has to do with the servers logic. All responses get this header right now
'Content-Type': 'text/html'
I saw there were comments in the code about this.
If no one else has time to work on this before saturday I'll see if I can get css and images working by using file extensions before saturday so i can demo my client.

@antimeme
Copy link
Owner

Give that a try. CSS, PNG and JPEG should be recognized now. We can add more types as necessary.

@KevinGage
Copy link
Collaborator Author

Thanks Jeff. I'll test it out tonight.

On Tue, Jul 21, 2015 at 11:48 PM, Jeff Gold notifications@github.com
wrote:

Give that a try. CSS, PNG and JPEG should be recognized now. We can add
more types as necessary.


Reply to this email directly or view it on GitHub
#9 (comment).

@jorgelr617
Copy link
Collaborator

Jeff, I'm curious as to when you say "I just tried accessing my client by browsing to it on the server". Why would you be accessing the client from the server? The client should be able to run from anywhere.

@antimeme
Copy link
Owner

I think you meant to direct that at Kevin, not me. But I interpreted that
as "I just tried to access my demo by pointing a browser at the server" or
some such. Before the change I made the server gave all files the content
type "text/html" which confused the browser where CSS and images were
concerned. I believe my change fixes this for at least some types so we
can expose more sophisticated web sites.

Does that make sense?

On Wed, Jul 22, 2015 at 3:57 PM, jorgelr617 notifications@github.com
wrote:

Jeff, I'm curious as to when you say "I just tried accessing my client by
browsing to it on the server". Why would you be accessing the client from
the server? The client should be able to run from anywhere.


Reply to this email directly or view it on GitHub
#9 (comment).

@KevinGage
Copy link
Collaborator Author

Yes sorry about the bad phrasing. Jeff is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants