Uses bundler with Gemfile, added rackup file (config.ru). #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't be merged as #127 adds a Gemfile already. If you want to resubmit a rackup file without load path, I will merge it. |
|
If we use ruby 2, (and I think ruby 1.9 as well), we need to require files with relative path (require './page' or require_relative 'page'), otherwise the app.rb file can't load the other files. Shall I push that commit too? |
|
In Debian Stable (Wheezy), the current Ruby version is 1.9.3 : http://packages.debian.org/wheezy/ruby So I believe it would make sense to target this version now. Any thoughts? |
|
Merged the rackup file, thank you. Also made the required changes to app.rb to make it Ruby 1.9.2+ compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.