Reconsider ErrorTypeConvertible #147
Conversation
This was changed in #141. But the current form does not looks correct since the `ConvertibleType` associated type is not used in any method signature. This change brings back the original definition and worked well for both Swift 2.2 on OS X and swift-DEVELOPMENT-SNAPSHOT-2016-03-24-a on Linux.
| } | ||
|
|
||
| public extension ResultType where Error: ErrorTypeConvertible { | ||
| public extension ResultType where Error: ErrorTypeConvertible, Error.ConvertibleType == Error { |
There was a problem hiding this comment.
I added the constraint to make the implementation here safer.
|
This is breaking API changes, but Result 2.0 is already released. So should this be shipped as 3.0? |
|
I did not use pre-release identifier of semver on 2.0.0 because of SwiftPM's current behavior. |
|
Just setting pre-release checkbox on at the GitHub release would not have any effects for SwiftPM or Carthage or CocoaPods, I think. |
|
If we would mark 2.0.0 as pre-release, should we continue marking new releases as pre-release until the release of Swift 3? |
|
But unfortunately, 2.0.0 release is already shipped as non-pre-release version, because the release has no pre-release identifiers as you said. So just adding pre-release mark on GitHub would not help anything. |
|
I'm so sorry that I did not tag 2.0.0 as pre-release. |
|
Is |
It seems that is still needed. |
|
I have an interest in the codes that would be affected by this change. |
|
I revisited this, and came to the thought that removing @antitypical/result Any thoughts? |
|
@ikesyo: Agreed 💯% re: |
|
Can I merge this? |
|
Looks good to me! 👍 |
This was changed in #141. But the current form does not looks correct since the
ConvertibleTypeassociated type is not used in any method signature.This change
brings back the original definitionremovesConvertibleTypefromErrorTypeConvertibleand worked well for both Swift 2.2 on OS X and swift-DEVELOPMENT-SNAPSHOT-2016-03-24-a on Linux.