-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swift version to 4.2 #271
Conversation
Thanks for the pr, but we would still like to keep Swift 4.0/4.1 compatiblity for a while. And also this is a breaking change so must be major version bump. |
I will update it for the major version bump. Can we have a swift-4.1 branch for swift 4.1 compatibility and master moved to latest swift version? |
Without any changes using the new features of Swift 4.2, what is the reason for updating to Swift 4.2? |
In my current project all pods are using Swift 4.2 except the Result and this gives me warning for upgrading the pods to Swift 4.2 . Yes, this is not an error/issue but still would like to clean things up. |
I am not sure about changing podspec. |
please merge this pull request |
please merge 2 commits into antitypical:master. Thanks |
@norio-nomura I don't think updating the swift-version will be an issue as we are also bumping the pod version. Previous version use can be used with Swift 4, as per my understanding. Is there anything else, which I should get correct to have this PR merged? As this seems to be request of many users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change SWIFT_VERSION
in Project build settings instead of adding SWIFT_VERSION
to each Target's build settings?
I have changed the |
+1 |
Any updates on this? These warnings are pretty annoying. |
Thanks! |
Bump swift version to 4.2 and also increment pod version.