Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift version to 4.2 #271

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

aksswami
Copy link
Contributor

Bump swift version to 4.2 and also increment pod version.

@ikesyo
Copy link
Member

ikesyo commented Sep 30, 2018

Thanks for the pr, but we would still like to keep Swift 4.0/4.1 compatiblity for a while. And also this is a breaking change so must be major version bump.

@aksswami
Copy link
Contributor Author

aksswami commented Oct 1, 2018

I will update it for the major version bump. Can we have a swift-4.1 branch for swift 4.1 compatibility and master moved to latest swift version?

@norio-nomura
Copy link
Contributor

Without any changes using the new features of Swift 4.2, what is the reason for updating to Swift 4.2?

@aksswami
Copy link
Contributor Author

aksswami commented Oct 1, 2018

In my current project all pods are using Swift 4.2 except the Result and this gives me warning for upgrading the pods to Swift 4.2 . Yes, this is not an error/issue but still would like to clean things up.

@norio-nomura
Copy link
Contributor

  • Changing the SWIFT_VERSION of the Xcode project to 4.2.
    As far as I tested, I do not think it will be a breaking change since it can be built with Xcode 9.0.1, 9.1, 9.2, 9.3.1 and 9.4.1 even if it be changed.

I am not sure about changing podspec.

@Jenus
Copy link

Jenus commented Oct 22, 2018

please merge this pull request

@Jenus
Copy link

Jenus commented Oct 22, 2018

please merge 2 commits into antitypical:master. Thanks

@aksswami
Copy link
Contributor Author

@norio-nomura I don't think updating the swift-version will be an issue as we are also bumping the pod version. Previous version use can be used with Swift 4, as per my understanding.

Is there anything else, which I should get correct to have this PR merged? As this seems to be request of many users.

Copy link
Contributor

@norio-nomura norio-nomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change SWIFT_VERSION in Project build settings instead of adding SWIFT_VERSION to each Target's build settings?

@aksswami
Copy link
Contributor Author

I have changed the SWIFT_VERSION in Project Build settings to 4.2.

@adrianod1as
Copy link

+1

@larsschwegmann
Copy link

Any updates on this? These warnings are pretty annoying.

@norio-nomura norio-nomura merged commit 3228eb3 into antitypical:master Dec 12, 2018
@norio-nomura
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants