Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a podspec (supporting watchOS, &c) #73

Closed
JARinteractive opened this issue Jul 22, 2015 · 6 comments
Closed

Add a podspec (supporting watchOS, &c) #73

JARinteractive opened this issue Jul 22, 2015 · 6 comments

Comments

@JARinteractive
Copy link

please update the platforms in the pod spec to support watchOS for 0.6-beta.1

@mdiep
Copy link
Contributor

mdiep commented Jul 23, 2015

Sorry, but the podspec isn't supported or maintained by this repo. It lies over here. I'd suggest opening a PR there to add watchOS. 😄

@ikesyo
Copy link
Member

ikesyo commented Jul 23, 2015

Pull requests on the Specs repo is not recommended way now: CocoaPods/Specs#12199. So you should contact the pod owners listed in the info by $ pod trunk info Result.

@mdiep mdiep closed this as completed Jul 23, 2015
@Thomvis
Copy link
Member

Thomvis commented Jul 23, 2015

Like @ikesyo mentioned, since the introduction of the CocoaPods trunk, it is no longer possible to update a podspec through a PR on the Cocoapods/Specs repo.

A few weeks ago, I updated the podspec for Result by manually pulling the json from the specs repo, making changes and push it again (like @gfontenot described). I'd be ok with doing this again for the requested change. We could also consider adding the .podspec to this repository, so people can update them with a PR if needed. That seems to be the approach most pods take.

@JARinteractive in the meantime, you can make a local copy of Result.podspec with watchOS support and use that one.

@robrix
Copy link
Contributor

robrix commented Jul 23, 2015

We could also consider adding the .podspec to this repository, so people can update them with a PR if needed. That seems to be the approach most pods take.

In the past I’ve been reluctant to add a .podspec because I’m not really able to maintain them myself, and it wasn’t really necessary. I think we have a sufficient mass of invested maintainers here (whether collaborators on the repo or folks willing to fork) that it’d be worth adding one if it will make API consumers’ lives easier.

I’m still not in a great position to write one myself, but if someone would like to submit a PR with one, I’d be grateful!

Going to repurpose this issue to track that in the meantime, too.

(And thanks for filing, @JARinteractive!)

@robrix robrix reopened this Jul 23, 2015
@robrix robrix changed the title Update podspec to support watchOS Add a podspec (supporting watchOS, &c) Jul 23, 2015
@gfontenot
Copy link
Member

I'm happy to maintain that, since I kind of already am. It'd be nice for it to be tracked here instead of in a random dir on my machine.

Opened a simple PR. Please make comments if I'm missing any crucial info.

@robrix
Copy link
Contributor

robrix commented Sep 18, 2015

Thanks @gfontenot ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants