Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request FAQ #12199

Closed
wants to merge 0 commits into from
Closed

Pull Request FAQ #12199

wants to merge 0 commits into from

Conversation

@orta
Copy link
Member

@orta orta commented May 23, 2014

Hello there, so you're thinking of making a Pull Request to the Specs repo?

Update 2016

We are working on removing the ability to ship PRs completely from the Specs repo. With the 1.0 release we have pod trunk commands that allow you to delete a CocoaPod version, or to deprecate an entire Pod. If you want to modify an existing CocoaPod you should be shipping a new patch version.

Pre-2016

Chances are very high that it will not get merged. Submitting a Pod via a pull request means that that there is no safety for everyone else. We take security seriously.

If you're not familiar with CocoaPods trunk, then I suggest you read the introduction blog post, and then the getting started guide. Then you can push your own versions whenever you want without our intervention.

Can I submit a pull request if...
Q: I want to update my Pod to a new version?

A: No, this is no longer the appropriate way to update your Pod. Pod updates must be uploaded using pod trunk push [NAME.podspec].

Q: I made a mistake in a Podspec I've just pushed?

A: No. The quickest way to get this fixed is to edit your .podspec, bump the version number and pod trunk push [NAME.podspec].

Q: I've deleted this Pod?

A: People are relying on your library, you should apply the deprecated flag via a pull request to all versions of your library. Removal of Podspecs should be avoided as much as possible. This is to ensure systems built around the CocoaPods ecosystem are kept in sync.

Q: No one needs that pod, or is going to ever download it... why can't I just delete it?

A: Our policy is to only perma-delete pods that really need it, such as Pods that may contain passwords, malicious/harmful code, etc. Deprecating a pod effectively removes it from being found and will do the trick in 99% percent of situations.

Q: But what if..

A: Chances are, no.

idealllee referenced this pull request in marcuswestin/WebViewJavascriptBridge Jul 9, 2014
This was referenced Jul 16, 2014
@keith keith mentioned this pull request Jun 17, 2015
This was referenced Jun 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant