Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warning 109 for matching options during import #707

Closed
sharwell opened this issue Sep 21, 2014 · 1 comment · Fixed by #713
Closed

Suppress warning 109 for matching options during import #707

sharwell opened this issue Sep 21, 2014 · 1 comment · Fixed by #713
Labels
comp:tool status:fixed type:bug
Milestone
ANTLR 4.5

Comments

@sharwell
Copy link
Member

Warning 109 is emitted if an imported grammar contains an options{} block. The warning should be suppressed in the specific case that an imported grammar contains an options{} block, where every option value matches the values specified in the root grammar. For example, if a root grammar an imported grammar each contain the following options, no warning should appear.

options {
  tokenVocab = FooLexer;
}
@parrt
Copy link
Member

parrt commented Sep 22, 2014

makes sense

sharwell added a commit to sharwell/antlr4 that referenced this issue Sep 26, 2014
@sharwell
Suppress OPTIONS_IN_DELEGATE warning if all options match the root gr…
f78f6ce 
…ammar (fixes antlr#707)
@sharwell sharwell mentioned this issue Sep 26, 2014
Merged
@sharwell sharwell modified the milestone: ANTLR 4.4.1 Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:tool status:fixed type:bug
Projects
None yet
Milestone
ANTLR 4.5
Development

Successfully merging a pull request may close this issue.

Improved support for recursive imports sharwell/antlr4
2 participants
@parrt @sharwell