Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Tool a bit to have a method to get the results as a string via API + some other refactorings #2774

Closed
wants to merge 1 commit into from

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Mar 12, 2020

I need to embed ANTLR into an another tool, so I have implemented an API to do this. The API allows

  • getting compilation results without saving them to disk;
  • triggerring TestRig tools programmatically

@parrt

@parrt
Copy link
Member

parrt commented Jun 16, 2020

Hi. Unfortunately, I can't take any major changes to the internals at this point. sorry!

@parrt parrt closed this Jun 16, 2020
@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jun 16, 2020

What do you mean under at this point? Do you mean I have no time to merge them currently (why have the PR been closed then? Does the project have other contributors capable to review with write access capable to review this properly and make a decision?) or I don't think currently that these changes are needed, but in unknown distant future (>= 5 years) I may have reconsidered (essentially wontfix)?

@parrt
Copy link
Member

parrt commented Jun 16, 2020

Meaning the tool is mature, I've moved on really, and any changes could have widespread effects on thousands of existing projects I'm afraid. It's not worth the risk. Sorry.

@KOLANICH
Copy link
Contributor Author

Thanks for stating that clearly. Could you, please, add to the Contributing clear criteria on what PRs have no chances to be merged?

@parrt
Copy link
Member

parrt commented Jun 16, 2020

Done. added generic 'no big changes' thing.

@parrt
Copy link
Member

parrt commented Jun 16, 2020

Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants