[C++ runtime] Add AntlrInputStream(std::string_view) constructor #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nburles
changed the title
Guarded by the __cplusplus macro so it is only available in C++17 or newer.
nburles
force-pushed
the
antlrinputstream_from_stringview
branch
from
5addd4a
to
254b144
Compare
mike-lischke
approved these changes
Sep 10, 2020
|
@parrt A nice C++ addition, ready to be merged. |
|
Yeah, there's definitely some areas that could benefit from the new functionality in C++17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarded by the
__cplusplusmacro as it is only available in C++17 or newer.This avoids a copy if the input is actually
char const *(due to implicit conversion tostd::stringin the pre-C++ 17 version), and performs the same if the input is actuallystd::string.