Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Core #42

Closed
sharwell opened this issue Nov 11, 2015 · 9 comments
Closed

Support .NET Core #42

sharwell opened this issue Nov 11, 2015 · 9 comments

Comments

@sharwell
Copy link
Member

@sharwell sharwell commented Nov 11, 2015

From @jeremymeng:

According to https://oren.codes/2015/07/29/targeting-net-core/, class libraries using Profile 259 can run on CoreClr as-is.

馃摑 This issue was split from #40.

@tlil
Copy link

@tlil tlil commented Mar 19, 2016

Hi @sharwell - do you have any roadmap for this, or even better, an ETA for when this will be done? Is it being worked on, or on hold for now?

Loading

@jeremymeng
Copy link

@jeremymeng jeremymeng commented May 6, 2016

@sharwell Are you waiting for the RC2 release too? Or is there anything we can help now to move this forward? Thanks!

Loading

@lextm
Copy link

@lextm lextm commented Aug 15, 2016

Seems like the discussion is now under antlr/antlr4#1142.

Though PCL profile 259 might run on .NET Core, I still think a dedicate port to .NET Core is required. The PCL port has removed too many APIs to adapt to the limited PCL API surface, while .NET Core (.NET Standard) does provide more. A dedicate port can add more types and ease the pains of migrating from .NET Framework to .NET Core.

Loading

@sharwell
Copy link
Member Author

@sharwell sharwell commented Aug 15, 2016

@lextm The other issue you linked to is for ANTLR 4. This is the repository for ANTLR 3.

A beta of ANTLR 4's original C# target with support for .NET Core was released to NuGet a few weeks ago.

As for ANTLR 3, PCL and .NET Standard do not differ by much. The only items removed are:

  1. ANTLRFileStream (use ANTLRStringStream instead)
  2. Serialization code for Exception types (generally no need to use this)
  3. Some uses of Console output for debugging (generally no need to use this)
  4. The ability to use output=template, because that would require a much more involved PCL release of StringTemplate 3

Loading

@jeremymeng
Copy link

@jeremymeng jeremymeng commented Sep 1, 2016

In My PR I added a project.json. Running dotnet restore then dotnet pack under Runtime/Antlr3.Runtime/ should output a nupkg that targets the same set of frameworks as the old package does, and two more: netstandar1.1 and netstandard1.3.

Loading

@sharwell
Copy link
Member Author

@sharwell sharwell commented Sep 13, 2016

This was fixed in #53 (for ANTLR 3) and #59 (for StringTemplate 4).

Loading

@sharwell sharwell closed this Sep 13, 2016
@sharwell sharwell added the fixed label Sep 13, 2016
@jeremymeng
Copy link

@jeremymeng jeremymeng commented Oct 24, 2016

@sharwell will there be a pre-release on nuget.org soon?

Loading

@richardsheppard-avalara
Copy link

@richardsheppard-avalara richardsheppard-avalara commented Dec 5, 2016

@sharwell just wondering if this will be made available on nuget anytime soon?

Loading

@sharwell
Copy link
Member Author

@sharwell sharwell commented Dec 5, 2016

I don't have a specific timeline, but it's a blocker for some other things I want to get done so hopefully I can get it resolved in a reasonable time.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants