Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard support for Antlr3.Runtime #52

Closed
wants to merge 1 commit into from

Conversation

jeremymeng
Copy link

@jeremymeng jeremymeng commented Aug 29, 2016

  • Add a multi-targeting project.json.
  • Also added <project_name>.project.json files to prevent MSBuild from using project.json to restore nuget dependencies for existing .csproj.
  • Add NO_<FEATURE_NAME> conditional compilation symbols to avoid modifying existing .csproj.

For #42

- Add a multi-targeting project.json.
- Also added <project_name>.project.json files to prevent MSBuild from using project.json to restore nuget dependencies for existing .csproj.
- Add NO_<FEATURE_NAME> conditional compilation symbols to avoid modifying existing .csproj.
@jeremymeng
Copy link
Author

The Antlr3.Runtime.Test project is too involved to port :(

@sharwell
Copy link
Member

sharwell commented Sep 1, 2016

I actually updated the existing .csproj a couple weeks ago, but didn't push the branch. I've opened #53 with the work done so far.

📝 I'm avoiding the .xproj format since it's going away.

@jeremymeng
Copy link
Author

@sharwell Glad to know that you have been working on this. I will close this PR. Regarding project.json/xproj I believe there will be migration support to the new project system.

@jeremymeng jeremymeng closed this Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants