Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TypeRegistry implementation of Map used for model adaptors and renderers #59

Merged
merged 1 commit into from
Mar 22, 2014

Conversation

sharwell
Copy link
Member

No description provided.

…renderers. This implementation maps keys according to the maximally-specific inheritance properties used by the Java language to match method signatures (JLS §15.12.2.5), and throws an AmbiguousMatchException if more than one value results from a lookup. (fixes antlr#57, fixes antlr#58)
@ghost ghost assigned sharwell Jun 30, 2013
@sharwell sharwell assigned parrt and unassigned sharwell Feb 25, 2014
@parrt
Copy link
Member

parrt commented Mar 21, 2014

Can you tell me what problem we're trying to solve? Is it that adding type to renderer mappings at the moment allows duplicates?

@sharwell
Copy link
Member Author

This change resolves issues #57 and #58, and makes the resolution process more intuitive for Java developers. From the commit comment:

Add a TypeRegistry implementation of Map used for model adaptors and renderers. This implementation maps keys according to the maximally-specific inheritance properties used by the Java language to match method signatures (JLS §15.12.2.5), and throws an AmbiguousMatchException if more than one value results from a lookup.

@parrt
Copy link
Member

parrt commented Mar 22, 2014

excellent work, Sam. Thanks.

parrt added a commit that referenced this pull request Mar 22, 2014
Add a TypeRegistry implementation of Map used for model adaptors and renderers
@parrt parrt merged commit fc592af into antlr:master Mar 22, 2014
@sharwell sharwell deleted the type-registry branch March 22, 2014 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants