Type safety of AttributeRenderer and ModelAdaptor #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converting them to generic interfaces.
|
Hi. some nice stuff here but I'd like to avoid adding generics. Happy to add your other changes if you want to make a new PR. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the type safety of AttributeRenderer and ModelAdaptor by converting them to generic interfaces.
Another goal behind this is to help dependency injection for
AttributeRenderers andModelAdaptors. If using a framework such as Guice, you can bind eachAttributeRenderer<SomeType>to an implementation. If the interface is not generic you have to create a separate binding annotation for eachAttributeRenderer, which requires a lot of boilerplate.