Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Am I doing something wrong? #51

Closed
rbanno opened this issue Nov 18, 2021 · 4 comments
Closed

Am I doing something wrong? #51

rbanno opened this issue Nov 18, 2021 · 4 comments

Comments

@rbanno
Copy link

rbanno commented Nov 18, 2021

When using the demo page for this component I tried using entering password and password123, the latter came back as a "green" password. This is a really common password, how comes the strength isn't lower?

If I do the same thing using: https://lowe.github.io/tryzxcvbn/, then this comes back with a score of 0.

Output from above:

_> password: | password123

guesses_log10: | 2.77525
score: | 0 / 4
function runtime (ms): | 0
guess times:
100 / hour: | 6 hours | (throttled online attack)
10  / second: | 60 seconds | (unthrottled online attack)
10k / second: | less than a second | (offline attack, slow hash, many cores)
10B / second: | less than a second | (offline attack, fast hash, many cores)
warning: | This is a very common password
suggestions: | - Add another word or two. Uncommon words are better._

Is this something that can be configured within the component?

@rbanno
Copy link
Author

rbanno commented Nov 18, 2021

Apologies, I tried the vue.js component and that worked as I would expect, so I am hopeful this is something that can be configured.

Please see the screen shots below, both testing with password123

Vue.js example
image

Angular example
image

@PooSham
Copy link

PooSham commented Jan 7, 2022

This package uses the npm package zxcvbn3 to calculate the score, not dropbox's original implementation. That npm package isn't maintained anymore (and probably not this one either). I might try to maintain a fork of this project where zxcvbn-ts is used as default (maybe with the possibility to easily inject another score calculator). zxcvbn-ts gives "password123" a score of 0, check it out here: https://zxcvbn-ts.github.io/zxcvbn/demo/

@rbanno
Copy link
Author

rbanno commented Jan 10, 2022 via email

@antoantonyk
Copy link
Owner

Hi all,

I just updated the lib with zxcvbn-ts. Hope this will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants