Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update versions #151

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore: update versions #151

merged 2 commits into from
Mar 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

skott@0.33.1

Patch Changes

  • #150 04fe22d Thanks @antoine-coulon! - This patch fixes the eager evaluation of cwd default value from the config preventing process.chdir
    to work as expected when used before invoking skott's API.

    process.chdir("/tmp/somewhere");
    
    // skott is now being executed at the root of "/tmp/somewhere"
    
    const instance = await skott();

    Note: regarding the generated graph relationships, this is pretty much equivalent as doing skott({ cwd: "/tmp/somewhere" }), even though
    node paths will be relative and won't have the same values as the later still executes skott from the script location
    and not from /tmp/somewhere. In other words, using cwd parameter will have node paths being relative to skott's script location, while using
    process.chdir will make skott execute the script from the provided directory.

    You can find a real example of the difference between node paths using process.chdir and cwd: process.chdir does not affect working directory used by skott for creating node id paths #149 (comment)
    by @mattkindy.

  • Updated dependencies []:

    • skott-webapp@2.1.1

@antoine-coulon antoine-coulon merged commit 695a067 into main Mar 12, 2024
6 checks passed
@antoine-coulon antoine-coulon deleted the changeset-release/main branch March 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant