Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update versions #151

Merged
merged 2 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .changeset/metal-pumas-wait.md

This file was deleted.

23 changes: 23 additions & 0 deletions packages/skott/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# skott

## 0.33.1

### Patch Changes

- [#150](https://github.com/antoine-coulon/skott/pull/150) [`04fe22d`](https://github.com/antoine-coulon/skott/commit/04fe22dacb585c51e597ab835f7bde274baa14ea) Thanks [@antoine-coulon](https://github.com/antoine-coulon)! - This patch fixes the eager evaluation of `cwd` default value from the config preventing [process.chdir](https://nodejs.org/api/process.html#processchdirdirectory)
to work as expected when used before invoking skott's API.

```js
process.chdir("/tmp/somewhere");

// skott is now being executed at the root of "/tmp/somewhere"

const instance = await skott();
```

Note: regarding the generated graph relationships, this is pretty much equivalent as doing `skott({ cwd: "/tmp/somewhere" })`, even though
node paths will be relative and won't have the same values as the later still executes skott from the script location
and not from `/tmp/somewhere`. In other words, using `cwd` parameter will have node paths being relative to skott's script location, while using
`process.chdir` will make skott execute the script from the provided directory.

You can find a real example of the difference between node paths using `process.chdir` and `cwd`: https://github.com/antoine-coulon/skott/issues/149#issuecomment-1989451725
by @mattkindy.

## 0.33.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/skott/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "skott",
"version": "0.33.0",
"version": "0.33.1",
"description": "Automatically construct and visualize Graphs generated from your JavaScript and TypeScript project",
"author": "Antoine Coulon",
"license": "MIT",
Expand Down
Loading