Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working api and clean and fix porfolio empty #96

Merged
merged 13 commits into from
Sep 23, 2023
Merged

working api and clean and fix porfolio empty #96

merged 13 commits into from
Sep 23, 2023

Conversation

antoinebou12
Copy link
Owner

@antoinebou12 antoinebou12 commented Sep 23, 2023

Summary
This pull request aims to address two main areas of concern:

Code Refactoring: The API code has been cleaned up to remove unused packages and streamline the configuration.
Portfolio Data: Fixed an issue where portfolio data was appearing empty.
Changes
Removed unused packages and import statements from api/app.py.
Updated requirements.txt to only include necessary dependencies.
Moved vercel.json to the root directory and updated its configuration.
Fixed the issue where portfolio data was appearing empty.
Testing
The API has been tested locally to ensure that all endpoints are functioning as expected, and the portfolio issue has been resolved.

Deployment
The vercel.json file has been updated to reflect changes in deployment settings.

@antoinebou12 antoinebou12 added bug Something isn't working enhancement New feature or request labels Sep 23, 2023
@antoinebou12 antoinebou12 added this to the v0.2.2 milestone Sep 23, 2023
@antoinebou12 antoinebou12 self-assigned this Sep 23, 2023
@vercel
Copy link

vercel bot commented Sep 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marketwatch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 8:05pm

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e40e8b) 71.09% compared to head (17ce309) 71.09%.

❗ Current head 17ce309 differs from pull request most recent head 151b4aa. Consider uploading reports for the commit 151b4aa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   71.09%   71.09%           
=======================================
  Files           5        5           
  Lines         595      595           
=======================================
  Hits          423      423           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinebou12 antoinebou12 merged commit d7ce4a9 into main Sep 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant