Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary output wrong #4

Closed
anton-johansson opened this issue Mar 23, 2020 · 0 comments · Fixed by #12
Closed

Summary output wrong #4

anton-johansson opened this issue Mar 23, 2020 · 0 comments · Fixed by #12
Labels
bug Something isn't working

Comments

@anton-johansson
Copy link
Owner

The summary output is wrong, it outputs a hardcoded version number:

version-lifecycle-maven-plugin/src/main/java/com/antonjohansson/versionlifecycleplugin/SummaryMojo.java

Line 32 in e8a417e

getLog().info("Run 'git push origin master && git push origin v1.0.0' to push your version");

@anton-johansson anton-johansson added the bug Something isn't working label Mar 23, 2020
@erikbrudzinskis erikbrudzinskis mentioned this issue Feb 10, 2024
Merged
anton-johansson pushed a commit that referenced this issue Mar 7, 2024
@erikbrudzinskis
Fix issues (#12)
6f50055 
Various improvements to improve stability of the plugin

* Output the correct information to push the created version (#4)
* Abort if there are uncommitted changes (#7)
* Support other default branches than `master` (#9)
* Update Java version from 8 to 11
* Update dependencies to get rid of some CVE's

Closes #4, #7 and #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues erikbrudzinskis/version-lifecycle-maven-plugin
1 participant
@anton-johansson