Fix issues #12
Merged
Fix issues #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 10, 2024 18:17
…, if any uncommitted changes are present.
…re snapshot version is not set
…erabilities and add commons-io to dependencies as it is no longer a part of maven-core
anton-johansson
requested changes
Feb 13, 2024
src/main/java/com/antonjohansson/versionlifecycleplugin/ValidateMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/antonjohansson/versionlifecycleplugin/ValidateMojo.java
Outdated
Show resolved
Hide resolved
|
Hmm, the |
|
I stole your commit that fixes the unit tests and put it in this one instead: #13. Lets get that one merged first, so we get the CI build working. |
Remove usage of deprecated methods Apply minor fixes
Remove usage of deprecated methods Fix tests by committing all uncommitted changes before execution Update Java version to 11,update dependencies to avoid high-risk vulnerabilities and add commons-io to dependencies as it is no longer a part of maven-core Allow preparing snapshot for any previous version to avoid a bug, where snapshot version is not set Add a check for uncommitted changes. By default, abort version change, if any uncommitted changes are present. Fix summary output to display correct branch and version Apply minor fixes
|
I have added the changes to You mentioned that |
Remove usage of deprecated methods Apply minor fixes
Add profile for artifact signing
…apshot for it anymore
Remove usage of deprecated methods Fix tests by committing all uncommitted changes before execution Update Java version to 11,update dependencies to avoid high-risk vulnerabilities and add commons-io to dependencies as it is no longer a part of maven-core Allow preparing snapshot for any previous version to avoid a bug, where snapshot version is not set Add a check for uncommitted changes. By default, abort version change, if any uncommitted changes are present. Fix summary output to display correct branch and version Apply minor fixes
Remove usage of deprecated methods Apply minor fixes
Remove usage of deprecated methods Apply minor fixes
Add profile for artifact signing
Remove usage of deprecated methods Fix tests by committing all uncommitted changes before execution Update Java version to 11,update dependencies to avoid high-risk vulnerabilities and add commons-io to dependencies as it is no longer a part of maven-core Allow preparing snapshot for any previous version to avoid a bug, where snapshot version is not set Add a check for uncommitted changes. By default, abort version change, if any uncommitted changes are present. Fix summary output to display correct branch and version Apply minor fixes
Remove usage of deprecated methods Apply minor fixes
Remove usage of deprecated methods Apply minor fixes
Add profile for artifact signing
Remove usage of deprecated methods Apply minor fixes
Remove usage of deprecated methods Apply minor fixes
anton-johansson
previously approved these changes
Mar 7, 2024
erikbrudzinskis
dismissed
anton-johansson’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Closes #7
Closes #9
Not entirely sure what's happened there. versions-maven-plugin:set does not seem to assume anything about the branches. It looks like it was trying to update the wrong version (i.e. 0.0.5 -> 0.0.7-SNAPSHOT, when it should have been 0.0.6 -> 0.0.7-SNAPSHOT). It couldn't find it and ignored "set version" altogether. As a result, it didn't work for me on any branch.
Possibly, there was a race condition, and sometimes it worked, sometimes it didn't. I.e. if MavenProject is correctly updated with the correct release version before we attempt to change it to snapshot, then it would work. Or it could have been some changes on Git side?
Anyway, allowing to update any old version seems to do the trick. Tested locally with main and master branches on different projects.
Other