Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TZAware.parse use dateutil #86

Closed
antonagestam opened this issue Mar 1, 2021 · 0 comments · Fixed by #234
Closed

Make TZAware.parse use dateutil #86

antonagestam opened this issue Mar 1, 2021 · 0 comments · Fixed by #234
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
1.0

Comments

@antonagestam
Copy link
Owner

antonagestam commented Mar 1, 2021 •
edited

If dateutil is installed we should use it to parse strings in TZAware.parse.

It will also make sense to make it use datetime.datetime.fromtimestamp for ints.

It might be necessary to take infinity into consideration, see this issue.
@antonagestam antonagestam added help wanted Extra attention is needed enhancement New feature or request labels Apr 21, 2021
@antonagestam antonagestam changed the title Add ext module for dateutil Make TZAware.parse use dateutil Nov 29, 2021
@antonagestam antonagestam mentioned this issue Apr 22, 2022
Closed
2 tasks
@antonagestam antonagestam added this to the 1.0 milestone Sep 24, 2022
@antonagestam antonagestam mentioned this issue Sep 24, 2022
Merged
5 tasks
antonagestam added a commit that referenced this issue Sep 24, 2022
@antonagestam
Give parsing abilities to datetime types (#234)
43c9ff5 
Closes #86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Give parsing ability to datetime types antonagestam/phantom-types
1 participant
@antonagestam