Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give parsing ability to datetime types #234

Merged
merged 11 commits into from Sep 24, 2022
Merged

Conversation

antonagestam
Copy link
Owner

@antonagestam antonagestam commented Sep 24, 2022

Closes #86.

Todo

  • Update documentation.
  • Address issue mentioned in Make TZAware.parse use dateutil #86 with regards to infinity.
  • Test that TZAware and TZNaive can be used without python-dateutil installed, as long as no attempts to parse strings are made.
  • Address coverage.
  • Coverage is no longer incremental within a run, gives wrong results ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022

Codecov Report

Merging #234 (45571c9) into main (1eee5f3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        26    +2     
  Lines          821       859   +38     
  Branches       172       175    +3     
=========================================
+ Hits           821       859   +38     
Impacted Files Coverage Δ
src/phantom/__init__.py 100.00% <100.00%> (ø)
src/phantom/_base.py 100.00% <100.00%> (ø)
src/phantom/bounds.py 100.00% <100.00%> (ø)
src/phantom/datetime.py 100.00% <100.00%> (ø)
src/phantom/errors.py 100.00% <100.00%> (ø)
src/phantom/ext/phonenumbers.py 100.00% <100.00%> (ø)
src/phantom/iso3166.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@antonagestam antonagestam marked this pull request as ready for review September 24, 2022 18:03
@antonagestam antonagestam merged commit 43c9ff5 into main Sep 24, 2022
@antonagestam antonagestam deleted the feature/datetime-parsing branch September 24, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TZAware.parse use dateutil
2 participants