Feedback from @MaxymVlasov

antonbabenko · Feb 22, 2022 · 456610b · 456610b
1 parent 2dd8fcb
commit 456610b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml
@@ -120,4 +120,4 @@
   require_serial: true
   files: \.tf$
   pass_filenames: false
-  args: ["terraform"]
+  args: ["--args=terraform"]
diff --git a/README.md b/README.md
@@ -635,8 +635,8 @@ Out of the box tfupdate will pin the terraform version
     - id: tfupdate
       name: tfupdate provider vsphere
       args:
-        - provider
-        - vsphere
+        - --args=provider
+        - --args=vsphere
 ```
 See the `tfupdate --help` command line help for available options. No need to pass `--recursive .` as it is added automatically
 

diff --git a/hooks/tfupdate.sh b/hooks/tfupdate.sh
@@ -8,14 +8,18 @@ source "$SCRIPT_DIR/_common.sh"
 
 function main {
   common::initialize "$SCRIPT_DIR"
-  tfupdate_ "$@"
+  common::parse_cmdline "$@"
+  # shellcheck disable=SC2153 # False positive
+
+  tfupdate_ "${ARGS[*]}" 
+
 }
 
 #######################################################################
 # tfupdate_
 #######################################################################
 function tfupdate_ {
-  local -r args=$*
+  local -r args="$1"
   # pass the arguments to hook
   # shellcheck disable=SC2086 # Double quote to prevent globbing and word splitting.
   tfupdate ${args} --recursive .