Skip to content

Commit

Permalink
fix: remove sed postprocessing from the terraform_docs_replace hook t…
Browse files Browse the repository at this point in the history
…o fix compatibility with terraform-docs 0.11.0+ (#176)
  • Loading branch information
choppedpork committed Feb 25, 2021
1 parent ad5dcca commit 90d4521
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
<a name="unreleased"></a>
## [Unreleased]

- fix: Removes sed post-processing from the `terraform_docs_replace` hook which was causing the last line to be missing when using `terraform-docs` 0.11.0+. Note: for older versions this change will result in an extra newline at the end of the file (making the pre-commit hook and `terraform-docs` output identical).


<a name="v1.46.0"></a>
Expand Down Expand Up @@ -123,7 +124,7 @@ All notable changes to this project will be documented in this file.

- fix: Change terraform_validate hook functionality for subdirectories with terraform files ([#100](https://github.com/antonbabenko/pre-commit-terraform/issues/100))

###
###

configuration for the appropriate working directory.

Expand Down
5 changes: 2 additions & 3 deletions pre_commit_hooks/terraform_docs_replace.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def main(argv=None):

dirs = []
for filename in args.filenames:
if (os.path.realpath(filename) not in dirs and \
if (os.path.realpath(filename) not in dirs and
(filename.endswith(".tf") or filename.endswith(".tfvars"))):
dirs.append(os.path.dirname(filename))

Expand All @@ -43,9 +43,8 @@ def main(argv=None):
procArgs.append('--sort-by-required')
procArgs.append('md')
procArgs.append("./{dir}".format(dir=dir))
procArgs.append("| sed -e '$ d' -e 'N;/^\\n$/D;P;D'")
procArgs.append('>')
procArgs.append("./{dir}/{dest}".format(dir=dir,dest=args.dest))
procArgs.append("./{dir}/{dest}".format(dir=dir, dest=args.dest))
subprocess.check_call(" ".join(procArgs), shell=True)
except subprocess.CalledProcessError as e:
print(e)
Expand Down

0 comments on commit 90d4521

Please sign in to comment.