Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding init to terraform_tflint hook #352

Merged
merged 3 commits into from
Apr 13, 2022
Merged

feat: Adding init to terraform_tflint hook #352

merged 3 commits into from
Apr 13, 2022

Conversation

andrew-glenn
Copy link
Contributor

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • [x ] This PR enhances existing functionality.

Description of your changes

Just a quick tflint --init before running tflint to ensure plugins are installed.

How can we test changes

hooks/terraform_tflint.sh Outdated Show resolved Hide resolved
hooks/terraform_tflint.sh Outdated Show resolved Hide resolved
@andrew-glenn
Copy link
Contributor Author

@yermulnik - feedback addressed.

@mbainter
Copy link
Contributor

@andrew-glenn I think you need to capitalize the a in Adding in your PR title for it to pass that still failing check.

@andrew-glenn andrew-glenn changed the title feat: adding init to terraform_tflint hook feat: Adding init to terraform_tflint hook Apr 12, 2022
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yermulnik
Copy link
Collaborator

yermulnik commented Apr 12, 2022

@antonbabenko @MaxymVlasov I haven't tested this PR, though it looks good and should not break anything. The failed PR check fix is here #358

@antonbabenko antonbabenko merged commit 1aff30f into antonbabenko:master Apr 13, 2022
antonbabenko pushed a commit that referenced this pull request Apr 13, 2022
# [1.65.0](v1.64.1...v1.65.0) (2022-04-13)

### Features

* Adding init to terraform_tflint hook ([#352](#352)) ([1aff30f](1aff30f))
@antonbabenko
Copy link
Owner

This PR is included in version 1.65.0 🎉

@MaxymVlasov
Copy link
Collaborator

Ok, I'll create separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hook/terraform_tflint Bash hook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants