Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed tfupdate to work in all cases, not only pre-commit run --all #375

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: Fixed tfupdate to work in all cases, not only pre-commit run --all #375

merged 1 commit into from
Apr 28, 2022

Conversation

MaxymVlasov
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Fixes #371

How can we test changes

repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: dfe39915d72182819814919b21b73a741ab9ae6a
  hooks:
    - id: tfupdate
      name: Autoupdate AWS provider versions
      args:
        - --args=provider aws
        - --args=--version 4.1.0
    - id: tfupdate
      name: Autoupdate Helm provider versions
      args:
        - --args=provider helm
    - id: tfupdate
      name: Update Google provider to specified version
      args:
        - --args=provider google
        - --args=--version 4.18.0
    - id: tfupdate
      name: Update Terraform provider to specified version
      args:
        - --args=terraform
        - --args=--version 1.1.8

@MaxymVlasov MaxymVlasov added bug Something isn't working estimate/1h Need 1 hour to be done hook/tfupdate Bash hook labels Apr 27, 2022
@MaxymVlasov MaxymVlasov changed the title fix: tfupdate now works in all cases , not only with --all fix: tfupdate now works in all cases , not only pre-commit run --all Apr 27, 2022
@MaxymVlasov MaxymVlasov self-assigned this Apr 27, 2022
@MaxymVlasov MaxymVlasov changed the title fix: tfupdate now works in all cases , not only pre-commit run --all fix: tfupdate now works in all cases, not only pre-commit run --all Apr 27, 2022
@MaxymVlasov MaxymVlasov changed the title fix: tfupdate now works in all cases, not only pre-commit run --all fix: TFupdate now works in all cases, not only pre-commit run --all Apr 27, 2022
@antonbabenko antonbabenko changed the title fix: TFupdate now works in all cases, not only pre-commit run --all fix: Fixed tfupdate to work in all cases, not only pre-commit run --all Apr 28, 2022
@antonbabenko antonbabenko merged commit 297cc75 into master Apr 28, 2022
@antonbabenko antonbabenko deleted the fix/GH-371/tfupdate branch April 28, 2022 07:06
antonbabenko pushed a commit that referenced this pull request Apr 28, 2022
@semantic-release-bot
chore(release): version 1.70.1 [skip ci]
aededd0 
## [1.70.1](v1.70.0...v1.70.1) (2022-04-28)

### Bug Fixes

* Fixed `tfupdate` to work in all cases, not only `pre-commit run --all` ([#375](#375)) ([297cc75](297cc75))
@antonbabenko
Copy link
Owner

This PR is included in version 1.70.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees

@MaxymVlasov MaxymVlasov

Labels
bug Something isn't working estimate/1h Need 1 hour to be done hook/tfupdate Bash hook
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

Successfully merging this pull request may close these issues.

tfupdate -> cannot find directory
3 participants
@MaxymVlasov @antonbabenko @yermulnik