Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Suppress color for all hooks if PRE_COMMIT_COLOR=never set #409

Merged
merged 10 commits into from
Jul 6, 2022
Merged

feat: Suppress color for all hooks if PRE_COMMIT_COLOR=never set #409

merged 10 commits into from
Jul 6, 2022

Conversation

MaxymVlasov
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

How can we test changes

repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: c86a8a428f59d84afb02587af3deb4bb61983351
PRE_COMMIT_COLOR=never pre-commit run -a

@MaxymVlasov MaxymVlasov changed the title feat: suppress color for all hooks if PRE_COMMIT_COLOR=never set feat: Suppress color for all hooks if PRE_COMMIT_COLOR=never set Jul 6, 2022
@MaxymVlasov MaxymVlasov mentioned this pull request Jul 6, 2022
Merged
yermulnik
yermulnik reviewed Jul 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hooks/terraform_docs.sh Outdated Show resolved Hide resolved
hooks/terraform_tfsec.sh Outdated Show resolved Hide resolved
MaxymVlasov
MaxymVlasov commented Jul 6, 2022
View reviewed changes
README.md Show resolved Hide resolved
MaxymVlasov
MaxymVlasov commented Jul 6, 2022
View reviewed changes
hooks/terraform_docs.sh Outdated Show resolved Hide resolved
@MaxymVlasov @yermulnik
Apply suggestions from code review
79e9497 
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
yermulnik
yermulnik approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hooks/infracost_breakdown.sh Show resolved Hide resolved
@MaxymVlasov MaxymVlasov merged commit 98a1a49 into pre-release Jul 6, 2022
@MaxymVlasov MaxymVlasov deleted the feat/no_color_support branch July 6, 2022 12:34
antonbabenko pushed a commit that referenced this pull request Jul 12, 2022
@MaxymVlasov @antonbabenko
feat: Suppress color for all hooks if PRE_COMMIT_COLOR=never set (#409
b12f0c6 
)
antonbabenko pushed a commit that referenced this pull request Jul 12, 2022
@semantic-release-bot
chore(release): version 1.74.0 [skip ci]
331e751 
# [1.74.0](v1.73.0...v1.74.0) (2022-07-12)

### Bug Fixes

* Add `--env-vars`, deprecate `--envs` ([#410](#410)) ([2b35cad](2b35cad))
* Add `--tf-init-args`, deprecate `--init-args` ([#407](#407)) ([c4f8251](c4f8251))

### Features

* Add support for set env vars inside hook runtime ([#408](#408)) ([d490231](d490231))
* Allow `terraform_providers_lock` specify terraform init args ([#406](#406)) ([32b232f](32b232f))
* Suppress color for all hooks if `PRE_COMMIT_COLOR=never` set ([#409](#409)) ([b12f0c6](b12f0c6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

Assignees
No one assigned
Labels
feature New feature or request hook/terraform_checkov Bash hook hook/terraform_docs Bash hook hook/terraform_fmt Bash hook hook/terraform_tfsec Bash hook
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxymVlasov @yermulnik