Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll2: update rlim.rlim_cur if it's too low #28

Merged
merged 1 commit into from Jan 6, 2021

Conversation

daxtens
Copy link
Contributor

@daxtens daxtens commented Aug 14, 2020

I saw some assertion failures on a test machine where the hard limit
for open files was adequate but the soft limit was too low. The
startup code only adjust the limits if the hard limit is inadequate.
Make it also check, and if necessary increase, the soft limit.

We make this a separate test so we don't accidentally lower the hard
limit by mistake!

Signed-off-by: Daniel Axtens dja@axtens.net

I saw some assertion failures on a test machine where the hard limit
for open files was adequate but the soft limit was too low. The
startup code only adjust the limits if the hard limit is inadequate.
Make it also check, and if necessary increase, the soft limit.

We make this a separate test so we don't accidentally lower the hard
limit by mistake!

Signed-off-by: Daniel Axtens <dja@axtens.net>
@mjguzik
Copy link

mjguzik commented Sep 8, 2020

I ran into the same problem and can confirm the patch fixes it.

What prevents this from getting in?

@mjguzik
Copy link

mjguzik commented Nov 15, 2020

@antonblanchard is there something which can be done to get this in?

@antonblanchard antonblanchard merged commit 566ada2 into antonblanchard:master Jan 6, 2021
@antonblanchard
Copy link
Owner

Thanks @daxtens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants