Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code highlight #31

Closed
antoniogamiz opened this issue Jul 7, 2019 · 8 comments
Closed

Code highlight #31

antoniogamiz opened this issue Jul 7, 2019 · 8 comments

Comments

@antoniogamiz
Copy link
Owner

Currently there is not code highlighting, so I will add the same process used at perl6/doc.

@antoniogamiz antoniogamiz added this to In progress in Release of version 1.0.0 Jul 7, 2019
antoniogamiz added a commit that referenced this issue Jul 7, 2019
@antoniogamiz antoniogamiz moved this from In progress to Done in Release of version 1.0.0 Jul 7, 2019
@JJ
Copy link
Collaborator

JJ commented Jul 7, 2019

I am not sure we want this also to be in this module... It might be a bit too much.
There are also issues with highlighting: perl6/doc#1430, for instance.

@antoniogamiz
Copy link
Owner Author

antoniogamiz commented Jul 7, 2019

I am aware of this problems and I tried to use https://highlightjs.org/, but it only has support for Perl. The results are quite good and it only needs to include some lines in template/head.html.

So we can either contribute to highlightjs with a Perl6 support (if we use highlightjs the perl6/doc#1430 issue would be solved) or we can leave this.

If this is not the place for that code, where do you think it should be placed? I remind you that atom-perl6 needs to be configured through a dynamic variable before calling Pod::To::HTML.

@JJ
Copy link
Collaborator

JJ commented Jul 7, 2019

Maybe a new htmlify binary in a Perl6::Htmlify module...

@antoniogamiz
Copy link
Owner Author

What do you think about Linguist. It's the used by GitHub and has perl6 support.

@JJ
Copy link
Collaborator

JJ commented Jul 7, 2019 via email

@antoniogamiz
Copy link
Owner Author

Mmm, but it is not that tool but it has to be something because GitHub hightlights the perl6 code.

@antoniogamiz
Copy link
Owner Author

Oh, it uses atom-perl6-language too => https://github.com/github/linguist/blob/master/vendor/README.md

@JJ
Copy link
Collaborator

JJ commented Jul 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants