Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bracket completion trigger #26

Merged
merged 6 commits into from
May 21, 2024

Conversation

moliva
Copy link
Contributor

@moliva moliva commented May 7, 2024

This is an extension to #25.

Introduces [ as a trigger character for completion, managing replacements avoiding to add wrapping characters if already present in file contents (mostly due to automatic edit tools completion).

@antonk52
Copy link
Owner

antonk52 commented May 8, 2024

Thanks for the PR. I am currently traveling. I will try to review this over the weekend/next week when I get back.

Copy link
Owner

@antonk52 antonk52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wait

A few nits and overall looks great, I've tested this locally and it works as advertised. Happy to merge once the comments are addressed 🙂

src/CompletionProvider.ts Show resolved Hide resolved
src/CompletionProvider.ts Outdated Show resolved Hide resolved
src/CompletionProvider.ts Show resolved Hide resolved
src/CompletionProvider.ts Outdated Show resolved Hide resolved
src/CompletionProvider.ts Outdated Show resolved Hide resolved
src/connection.ts Outdated Show resolved Hide resolved
@moliva moliva force-pushed the feat/bracket-completion-trigger branch from 1c1774a to bd8d3d0 Compare May 21, 2024 17:39
@antonk52 antonk52 merged commit e4d4c77 into antonk52:main May 21, 2024
@moliva moliva deleted the feat/bracket-completion-trigger branch May 21, 2024 21:08
@antonk52
Copy link
Owner

Thanks!

Released in 1.4.0 and published to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants