-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bracket completion trigger #26
feat: bracket completion trigger #26
Conversation
Thanks for the PR. I am currently traveling. I will try to review this over the weekend/next week when I get back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the wait
A few nits and overall looks great, I've tested this locally and it works as advertised. Happy to merge once the comments are addressed 🙂
1c1774a
to
bd8d3d0
Compare
Thanks! Released in 1.4.0 and published to npm |
This is an extension to #25.
Introduces
[
as a trigger character for completion, managing replacements avoiding to add wrapping characters if already present in file contents (mostly due to automatic edit tools completion).