Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Incorrect Variable Source Assignment in Nested Controls #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions OpenXMLTemplates/ControlReplacers/RepeatingControlReplacer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@
OnInnerControlReplacementEnqueued(exInner);

//Support old styled documents
var innerRep1 = new InnerRepeatingVariableControlReplacer();

Check warning on line 81 in OpenXMLTemplates/ControlReplacers/RepeatingControlReplacer.cs

View workflow job for this annotation

GitHub Actions / Build and test

'InnerRepeatingVariableControlReplacer' is obsolete: 'Use normal variable tags instead'

Check warning on line 81 in OpenXMLTemplates/ControlReplacers/RepeatingControlReplacer.cs

View workflow job for this annotation

GitHub Actions / Build and test

'InnerRepeatingVariableControlReplacer' is obsolete: 'Use normal variable tags instead'
var innerRep2 = new InnerRepeatingConditionalRemoveControlReplacer();

Check warning on line 82 in OpenXMLTemplates/ControlReplacers/RepeatingControlReplacer.cs

View workflow job for this annotation

GitHub Actions / Build and test

'InnerRepeatingConditionalRemoveControlReplacer' is obsolete: 'Use normal conditional remove tags instead'

Check warning on line 82 in OpenXMLTemplates/ControlReplacers/RepeatingControlReplacer.cs

View workflow job for this annotation

GitHub Actions / Build and test

'InnerRepeatingConditionalRemoveControlReplacer' is obsolete: 'Use normal conditional remove tags instead'
innerRep1.ReplaceAll(ex.Controls, ex.VariableSource);
innerRep2.ReplaceAll(ex.Controls, ex.VariableSource);
innerRep1.ReplaceAll(ex.Controls, innerSource);
innerRep2.ReplaceAll(ex.Controls, innerSource);

break;
}
Expand Down