Fix for Incorrect Variable Source Assignment in Nested Controls #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tire VariableSource instead of the required nested inner source.
|
I just saw that this pull request addresses a 2 year old issue. It was mentioned in #32, presumably a workaround has been found. I tested it and found that this workaround (replacing "repeatingitem" with "variable") doesn't currently work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves an issue identified in RepeatingControlTests within Tests.cs, where the document fields were not being populated with data from data.json. Specifically, the complexItems array was causing the problem, leading to the addition of empty lines instead of the expected data in the output document.
Original Issue Description.
The original problem occurred when nested controls were mistakenly assigned the entire VariableSource instead of the specific nested inner source required for the complexItems array. This resulted in the document rendering two empty rows under "Complex, Legacy (using repeatingitem)" despite the presence of data meant to populate these fields.
Changes Made.
Corrected the source assignment in the code to ensure that nested controls receive the correct nested inner source from VariableSource.
Request for Review.
I kindly request a review of this pull request to confirm the fix resolves the issue without affecting other functionalities. Any feedback or additional checks suggested by the team would be greatly appreciated to ensure comprehensive resolution.
Connection to Original Issue.
This pull request aims to address and close the issue concerning data population in nested controls. The issue discussion can be found here: #50