Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-actions-10 #33

Closed
wants to merge 27 commits into from
Closed

test-actions-10 #33

wants to merge 27 commits into from

Conversation

antonvoznia
Copy link
Owner

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Bug Fix / New Feature / Enhancement / Other?

  • Impact: Low / Normal / High / Critical / Urgent

  • Reference to related issue (URL):

  • How was this pull request tested?

  • Brief description of the changes in this pull request:

echo "Does it split the if?"
f

if [[ $var2 == 12 ]]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
The mentioned syntax error was in this if expression. SC1009

if [[ $var2 == 12 ]]; then
echo "unusedvar == 120"
echo "Does it split the if?"
elif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Couldn't parse this elif clause. Fix to allow more checks. SC1073


if [[ $no_var == 12 ]]; then
echo "The text will not be printed..."
fi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Fix any mentioned problems and try again. SC1072

@@ -0,0 +1,165 @@
#

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148


# Determine the actually used disk sizes on the original system and
# remember each one only once in the original_system_used_disk_sizes array:
local original_system_used_disk_sizes=()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
'local' is only valid in functions. SC2168

# with a relatively short timeout to avoid too much delay by default
# but sufficient time for the user to read and understand the message
# so that the user could deliberately intervene and enforce MIGRATION_MODE:
local timeout=3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
'local' is only valid in functions. SC2168

# e.g. for automated testing a small USER_INPUT_TIMEOUT may be specified and
# we do not want to delay it here more than what USER_INPUT_TIMEOUT specifies:
test "$timeout" -gt "$USER_INPUT_TIMEOUT" && timeout="$USER_INPUT_TIMEOUT"
local prompt="Proceed with '$WORKFLOW' (yes) otherwise manual disk layout configuration is enforced"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
'local' is only valid in functions. SC2168

# we do not want to delay it here more than what USER_INPUT_TIMEOUT specifies:
test "$timeout" -gt "$USER_INPUT_TIMEOUT" && timeout="$USER_INPUT_TIMEOUT"
local prompt="Proceed with '$WORKFLOW' (yes) otherwise manual disk layout configuration is enforced"
local input_value=""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
'local' is only valid in functions. SC2168

test "$timeout" -gt "$USER_INPUT_TIMEOUT" && timeout="$USER_INPUT_TIMEOUT"
local prompt="Proceed with '$WORKFLOW' (yes) otherwise manual disk layout configuration is enforced"
local input_value=""
local wilful_input=""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
'local' is only valid in functions. SC2168

local wilful_input=""
input_value="$( UserInput -I DISK_LAYOUT_PROCEED_RECOVERY -t "$timeout" -p "$prompt" -D 'yes' )" && wilful_input="yes" || wilful_input="no"
if is_true "$input_value" ; then
is_true "$wilful_input" && LogPrint "User confirmed to proceed with '$WORKFLOW'" || LogPrint "Proceeding with '$WORKFLOW' by default"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Note that A && B || C is not if-then-else. C may run when A is true. SC2015

@github-actions
Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant