Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Fastlane file structure #11

Closed
antonyhaman opened this issue Apr 12, 2020 · 10 comments
Closed

Move to Fastlane file structure #11

antonyhaman opened this issue Apr 12, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@antonyhaman
Copy link
Owner

#7 (comment)

@antonyhaman antonyhaman added the enhancement New feature or request label Apr 12, 2020
@antonyhaman antonyhaman self-assigned this Apr 12, 2020
@IzzySoft
Copy link

Ugh… I should read first… Just created a duplicate in #12 😱 Fixing that, moving the contents over here:

Great you consider Fastlane! Again, please let me know when it's there (I might also have "improvement suggestions" then), so I include it here as well (for now, the changelogs automatically and screenshots manually – in the future, maybe more). For the screenshots: I recommend not framing them (wastes the already minimal screen-estate on phones). I usually shrink them to a width of 350px; if you want to have a higher res, no issue as I srhink them myself anyway – but I'd not make them too big.

Attached you can find a "starter package" you'd just need to unzip into the root directory of your project: com.github.kotvertolet.youtubeaudioplayer_fastlane.zip

To fill the gaps, find a quick overview here: Fastlane file structure

antonyhaman added a commit that referenced this issue Apr 14, 2020
#11 Move to Fastlane file structure, #13 Get rid of fixed portrait or…
@antonyhaman
Copy link
Owner Author

antonyhaman commented Apr 14, 2020

@IzzySoft Done, check if everything is correct plase. Btw, I've updated readme too.

@IzzySoft
Copy link

I'd avoid <h1|2> headers in full_decription.txt – that will look ugly in the F-Droid app and on the website. Also, no need to put the app name in a big header on top – I'm not aware of any place where the description is used without mentioning the app name along already, so that is redundant.

Apart from that, it looks fine 😃

@antonyhaman
Copy link
Owner Author

@IzzySoft Thanks, fixed.

@IzzySoft
Copy link

Yes, much better! If you wish you can also put the <b>Features</b> between <p></p> – and later add a changelogs/<versionCode>.txt right before tagging a new release.

Thanks a lot!

@antonyhaman
Copy link
Owner Author

Please, check the latest commit if everything is right this time )

@IzzySoft
Copy link

IzzySoft commented Apr 14, 2020

Perfect! 🎉 👍 Provided your versionCodes are 110 and 111 that is. build.gradle says 1 and 2 – so the files should be 1.txt resp. 2.txt (versionCode, not versionName-without-dots 😉)

@IzzySoft
Copy link

IzzySoft commented Apr 14, 2020

PS: Please do NOT delete old releases, just keep them and add new ones. Tags are not consuming any space. And remember not to repeat versionCodes – always increase them before creating the APK and tagging the release. You already had 2 versions, so VC should be > 2 with the next one.

antonyhaman added a commit that referenced this issue Apr 14, 2020
@antonyhaman
Copy link
Owner Author

@IzzySoft Okey, I fixed that.

PS: Please do NOT delete old releases, just keep them and add new ones. Tags are not consuming any space. And remember not to repeat versionCodes – always increase them before creating the APK and tagging the release. You already had 2 versions, so VC should be > 2 with the next one.

Okay, I'll remeber that :) I'm closing this issue for now if you yave any other suggestions or recommendations feel free to create a new issue

@IzzySoft
Copy link

Will do! Thanks for your great work, was fun working with you on this! Keep it up 😄

PS: Looking forward to your next release. Just switched the config to fetch from releases now, including Fastlane per-release changelogs. Next update run in about 21h 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants