Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please sign your APK #7

Closed
IzzySoft opened this issue Apr 4, 2020 · 4 comments
Closed

Please sign your APK #7

IzzySoft opened this issue Apr 4, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@IzzySoft
Copy link

IzzySoft commented Apr 4, 2020

Your latest APK is lacking a valid signature:

DOES NOT VERIFY
ERROR: No JAR signatures
ERROR: com.github.kotvertolet.youtubeaudioplayer_2020-04-02.apk: 
ERROR: Old APK signature failed to verify: com.github.kotvertolet.youtubeaudioplayer_2020-04-02.apk

jar is unsigned.

Could you please replace it with a signed (v1+v2) APK? Thanks!

@antonyhaman
Copy link
Owner

@IzzySoft Check now, should be fixed in the latest release. Btw it's also announced some new improvements to the app.

@IzzySoft
Copy link
Author

Thanks! Yes, this worked out fine. Just versionName is a bit strange, considering you started with v1.0 about a year ago, which was followed by v1.1 🤣 Shouldn't the last release be v1.1.1, v1.2 or something like that, instead of v0.1.1?

Great also to see the size went down from ~30M to ~5M per APK, yay! And you finally increased versionCode 👍 So I've adjusted the settings for your app to allow for 3 versions, which now easily fit inside the 30M limit (ugh, ahem, referring to this – apologies for the late disclosure).

also announced some new improvements to the app

I don't know where to see that announcement (outside of the app itself). Maybe you should consider using releases? There you could add release notes. And it would keep your repo more compact if the APKs where attached to releases/ instead of living inside the repo.

While on it: what do you think about Fastlane file structure? Not that it much matters to you as you cannot publish to Google Play anyway – but my updater would pick the per-release changelogs from there, and should you get your app listed in F-Droid's main repo they'd also pick summary, description and screenshots.

@antonyhaman
Copy link
Owner

Just versionName is a bit strange, considering you started with v1.0 about a year ago, which was followed by v1.1 🤣 Shouldn't the last release be v1.1.1, v1.2 or something like that, instead of v0.1.1?

Ahah, you're right, it's strange ) In fact I'm not an android developer really and I'm not used to Gradle (I'm dedicated Maven user), I've found out about versionName and versionCode couple hours ago, when I started to google why my app can't be updated with new apk. So you suggest to start versioning from v1.1.1? Or start it all over from 1.0.0?

Great also to see the size went down from ~30M to ~5M per APK, yay!

Currently I'm trying to get proguard work again, apk size will shrink even more.

ugh, ahem, referring to this – apologies for the late disclosure

Wow, thanks for publishing this!

Maybe you should consider using releases? There you could add release notes. And it would keep your repo more compact if the APKs where attached to releases/ instead of living inside the repo.

Yeah, It would be nice tough. I will do it that way next time.

While on it: what do you think about Fastlane file structure? Not that it much matters to you as you cannot publish to Google Play anyway – but my updater would pick the per-release changelogs from there, and should you get your app listed in F-Droid's main repo they'd also pick summary, description and screenshots.

Okay, sounds reasonable, I'll do that.

Thanks for your suggestions a lot! Please let me know if you have any left )

@antonyhaman antonyhaman self-assigned this Apr 12, 2020
@antonyhaman antonyhaman added the enhancement New feature or request label Apr 12, 2020
@IzzySoft IzzySoft mentioned this issue Apr 12, 2020
@IzzySoft
Copy link
Author

IzzySoft commented Apr 12, 2020

So you suggest to start versioning from v1.1.1?

I'd just suggest keeping it straight with future releases. If you wish to "cleanup" now, just rebuild the APK with v1.1.1 as versionName (keep the versionCode this time as not too many people will already have loaded it) – but when doing so please drop me a note once the file has been replaced, as I'd need to pull that one manually.

Currently I'm trying to get proguard work again, apk size will shrink even more.

Yay, it gets even cooler 🎉

Wow, thanks for publishing this!

Gladly! And please let me know when you switched to releases/ as I need to adjust this here then as well for new APKs to be picked up. Besides, if you wish to point out in the Readme that your app is available with my repo (and thus can be installed/updated using the F-Droid client), you're welcome to use my badge for that:

Great you consider Fastlane! To help keeping things organized, I've split this off to #12 added the details to #11.

As for "recommendations left": Sure, as soon as they come to mind 😄

Thanks a lot – it's fun to "brain storm" if ideas fall on such fertile ground 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants