Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #[must_use] to see where we forget to use the call #3

Closed
wants to merge 1 commit into from

Conversation

mubarak23
Copy link

No description provided.

@antoyo
Copy link
Owner

antoyo commented Mar 21, 2024

@mubarak23: Sorry if I wasn't clear in the description. The PR needs to be done against the gccjit.rs repository and you need to add the #[must_use] attribute directly on the definition of the function Context::new_call() right here so that we get a warning on the usage of this function.
I hope this is more clear.

@mubarak23
Copy link
Author

i see, i get this now, i will clone the repo and continue from their, it' best we close this PR, @antoyo

@mubarak23
Copy link
Author

@antoyo checkout the PR LINK

@antoyo
Copy link
Owner

antoyo commented Mar 21, 2024

Thanks. I'll check it out.

@antoyo antoyo closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants