Revise OVS pipeline: use macRewriteMark as the only mark to reset dst MAC

[wenyingd]

Some flow entries are using the global vMAC as the mark when resetting dst MAC, while
others are using macRewriteMark originally. With this change, macRewriteMark is working
as the only mark.

[antrea-bot]

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

• /test-e2e: to trigger e2e tests.
• /skip-e2e: to skip e2e tests.
• /test-conformance: to trigger conformance tests.
• /skip-conformance: to skip conformance tests.
• /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
• /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
• /test-whole-conformance: to trigger all conformance tests on linux.
• /skip-whole-conformance: to skip all conformance tests on linux.
• /test-networkpolicy: to trigger networkpolicy tests.
• /skip-networkpolicy: to skip networkpolicy tests.
• /test-windows-conformance: to trigger windows conformance tests.
• /skip-windows-conformance: to skip windows conformance tests.
• /test-windows-networkpolicy: to trigger windows networkpolicy tests.
• /skip-windows-networkpolicy: to skip windows networkpolicy tests.
• /test-hw-offload: to trigger ovs hardware offload test.
• /skip-hw-offload: to skip ovs hardware offload test.
• /test-all: to trigger all tests (except whole conformance).
• /skip-all: to skip all tests (except whole conformance).

[codecov-io]

Codecov Report

Merging #1597 (f14bcdc) into master (408ce60) will increase coverage by 13.07%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master    #1597       +/-   ##
===========================================
+ Coverage   48.31%   61.39%   +13.07%     
===========================================
  Files         177      196       +19     
  Lines       15001    18998     +3997     
===========================================
+ Hits         7248    11664     +4416     
+ Misses       6824     6183      -641     
- Partials      929     1151      +222     

Flag	Coverage Δ
e2e-tests	49.06% <80.00%> (+0.74%)	⬆️
kind-e2e-tests	52.66% <100.00%> (?)
unit-tests	40.41% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/openflow/pipeline.go	74.00% <80.00%> (+14.60%)	⬆️
pkg/antctl/transform/networkpolicy/transform.go	15.00% <0.00%> (-45.00%)	⬇️
pkg/controller/networkpolicy/store/addressgroup.go	86.79% <0.00%> (-3.78%)	⬇️
pkg/agent/util/iptables/iptables.go	56.48% <0.00%> (-3.26%)	⬇️
pkg/agent/flowexporter/flowrecords/flow_records.go	81.96% <0.00%> (-2.65%)	⬇️
pkg/agent/flowexporter/exporter/exporter.go	77.27% <0.00%> (-0.45%)	⬇️
pkg/antctl/antctl.go	100.00% <0.00%> (ø)
pkg/antctl/transform/appliedtogroup/transform.go	0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/npl_agent_init.go	0.00% <0.00%> (ø)
pkg/agent/nodeportlocal/k8s/annotations.go	0.00% <0.00%> (ø)
... and 106 more

[wenyingd]

/test-all-features-conformance
/test-all

[jianjuns]

Could we change l3FwdFlowToGateway() as well?

You should update the comments on marRewriteMark.

[jianjuns]

/test-all

[jianjuns]

/test-windows-networkpolicy

[jianjuns]

Wenying is taking leave. Probably let us merge this PR first. I will take over and revise code comments and documentation.