Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update governance #2197

Merged
merged 2 commits into from
May 28, 2021
Merged

Update governance #2197

merged 2 commits into from
May 28, 2021

Conversation

antoninbas
Copy link
Contributor

  • switch to cncf-antrea-maintainers@lists.cncf.io as the maintainers
    mailing list
  • use the CNCF code of conduct
  • define antrea-io Github org membership and how to become a member
  • clarify PR merging process

@antoninbas
Copy link
Contributor Author

I am hoping that Github changes the permission model for Github actions in the near future, and that we can reduce permission level for members from "Write" to "Triage".

@antoninbas antoninbas added the cncf/sandbox Issues related to the CNCF Sandbox onboarding label May 20, 2021
jianjuns
jianjuns previously approved these changes May 20, 2021
GOVERNANCE.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #2197 (980aba5) into main (9547582) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   41.31%   41.28%   -0.03%     
==========================================
  Files         139      139              
  Lines       17225    17225              
==========================================
- Hits         7117     7112       -5     
- Misses       9484     9487       +3     
- Partials      624      626       +2     
Flag Coverage Δ
unit-tests 41.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/certificate.go 69.86% <0.00%> (-6.85%) ⬇️

tnqn
tnqn previously approved these changes May 21, 2021
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. A minor comment.

GOVERNANCE.md Outdated Show resolved Hide resolved
@antoninbas
Copy link
Contributor Author

/skip-all

tnqn
tnqn previously approved these changes May 24, 2021
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jianjuns
jianjuns previously approved these changes May 24, 2021
GOVERNANCE.md Outdated
duration of 12 months (no contribution of any kind), they may be removed from
the antrea-io Github organization. In case of privilege abuse (members receive
write access to the organization), any maintainer can decide to remove the
member.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a minor change to require always a consensus of at least 2 maintainers before removing write access rights. This in order avoid situations where misunderstandings can lead maintainers to take actions that might be perceived incorrectly as it happened in a recent incident in the Linux kernel community.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit conflicted. I see your point and I did think about this originally. But my intent was to enable a maintainer to act swiftly, since write privileges can be abused in a somewhat disruptive way I think, even with branch protection.

Maybe I should rephrase it along these lines:

In case of privilege abuse (members receive write access to the organization), any maintainer can decide to disable write access temporarily for the member. Within the next 2 weeks, the maintainer must either restore the member's privileges, or remove the member from the organization. The latter requires approval from at least one other maintainer, which must be obtained publicly either on Github or Slack.

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

* switch to cncf-antrea-maintainers@lists.cncf.io as the maintainers
  mailing list
* use the CNCF code of conduct
* define antrea-io Github org membership and how to become a member
* clarify PR merging process

Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit b6d7b61 into antrea-io:main May 28, 2021
@antoninbas antoninbas deleted the update-governance branch May 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf/sandbox Issues related to the CNCF Sandbox onboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants