-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node and EndpointSlice handlers to metaProxier #4641
Add Node and EndpointSlice handlers to metaProxier #4641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4641 +/- ##
==========================================
- Coverage 69.93% 68.46% -1.47%
==========================================
Files 400 401 +1
Lines 59457 58496 -961
==========================================
- Hits 41582 40051 -1531
- Misses 15077 15651 +574
+ Partials 2798 2794 -4
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
e2e failed on known flaky test #4477 |
Do you know why "Check tidy, code generation and manifest" is failing? |
3523dd1
to
3e3cda6
Compare
I run this test based this patch, and it passed. I'll add a |
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
bcc663b
to
944dd13
Compare
Resovled @tnqn |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-ipv6-all |
/skip-e2e which failed on known flaky test |
/skip-e2e |
Signed-off-by: Hongliang Liu lhongliang@vmware.com