Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node and EndpointSlice handlers to metaProxier #4641

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

hongliangl
Copy link
Contributor

Signed-off-by: Hongliang Liu lhongliang@vmware.com

@hongliangl hongliangl requested a review from tnqn February 20, 2023 06:53
@hongliangl hongliangl added the area/proxy Issues or PRs related to proxy functions in Antrea label Feb 20, 2023
@hongliangl hongliangl added this to the Antrea v1.11 release milestone Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #4641 (a638a3f) into main (cf90cfa) will decrease coverage by 1.47%.
The diff coverage is 60.34%.

❗ Current head a638a3f differs from pull request most recent head 944dd13. Consider uploading reports for the commit 944dd13 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4641      +/-   ##
==========================================
- Coverage   69.93%   68.46%   -1.47%     
==========================================
  Files         400      401       +1     
  Lines       59457    58496     -961     
==========================================
- Hits        41582    40051    -1531     
- Misses      15077    15651     +574     
+ Partials     2798     2794       -4     
Flag Coverage Δ *Carryforward flag
e2e-tests 38.40% <43.96%> (+0.06%) ⬆️
integration-tests 34.49% <0.00%> (-0.09%) ⬇️ Carriedforward from 944dd13
kind-e2e-tests 41.28% <63.63%> (-5.81%) ⬇️ Carriedforward from 944dd13
unit-tests 59.78% <80.51%> (+<0.01%) ⬆️ Carriedforward from 944dd13

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <ø> (ø)
pkg/agent/route/route_windows.go 34.64% <ø> (ø)
pkg/agent/route/route_linux.go 64.36% <5.12%> (-7.30%) ⬇️
pkg/agent/servicecidr/discoverer.go 88.31% <88.31%> (ø)
pkg/agent/util/ethtool/ethtool_linux.go 0.00% <0.00%> (-70.00%) ⬇️
...g/agent/controller/serviceexternalip/controller.go 35.83% <0.00%> (-43.35%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 29.62% <0.00%> (-22.23%) ⬇️
pkg/agent/ipassigner/responder/arp_responder.go 55.29% <0.00%> (-17.65%) ⬇️
...pportbundlecollection/support_bundle_controller.go 47.98% <0.00%> (-17.59%) ⬇️
pkg/agent/proxy/topology.go 66.66% <0.00%> (-15.16%) ⬇️
... and 56 more

tnqn
tnqn previously approved these changes Feb 20, 2023
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Feb 20, 2023

/test-all

@hongliangl
Copy link
Contributor Author

e2e failed on known flaky test #4477

@tnqn
Copy link
Member

tnqn commented Feb 20, 2023

Do you know why "Check tidy, code generation and manifest" is failing?

@hongliangl hongliangl force-pushed the 20230220-add-handlers-to-metaproxy branch 2 times, most recently from 3523dd1 to 3e3cda6 Compare February 21, 2023 01:22
@hongliangl
Copy link
Contributor Author

hongliangl commented Feb 21, 2023

Do you know why "Check tidy, code generation and manifest" is failing?

I run this test based this patch, and it passed. I'll add a -x option to the corresponding script hack/add-license.sh to see the output on github action to see the output.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl force-pushed the 20230220-add-handlers-to-metaproxy branch from bcc663b to 944dd13 Compare February 21, 2023 07:24
@hongliangl
Copy link
Contributor Author

Do you know why "Check tidy, code generation and manifest" is failing?

Resovled @tnqn

@hongliangl
Copy link
Contributor Author

/test-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Feb 21, 2023

/test-ipv6-all
/test-ipv6-only-all

@tnqn
Copy link
Member

tnqn commented Feb 22, 2023

/skip-e2e which failed on known flaky test

@tnqn
Copy link
Member

tnqn commented Feb 22, 2023

/skip-e2e

@tnqn tnqn merged commit aafea18 into antrea-io:main Feb 22, 2023
@hongliangl hongliangl deleted the 20230220-add-handlers-to-metaproxy branch March 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Issues or PRs related to proxy functions in Antrea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants