-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Update OVS version to 2.13.1 #856
Conversation
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
/test-all |
Signed-off-by: Rui Cao <rcao@vmware.com>
/test-all |
/test-conformance |
/test-networkpolicy |
hack/windows/Install-OVS.ps1
Outdated
$OVSDownloadURL = "http://downloads.antrea.io/ovs/ovs-2.12.90-win64.zip" | ||
$OVSPublishedHash = 'B5278BE3EFFEE322DFB71FABE97B0E4F5C1341CE31D609FD60E8B41D20416C2D' | ||
$OVSDownloadURL = "http://downloads.antrea.io/ovs/ovs-2.13.1-win64.zip" | ||
$OVSPublishedHash = 'bc927e2de8560f2f0d8c2fccd6d69de3d7f4c2c032bf81658d082aa7583b241d' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Get-FileHash
returned an hex string with capitalized letters and that we needed to do the same here, or the sanity check below would fail. Is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Antonin. I update the string to capitalized lettters.
It's interesting that the default compare for string in powershell is not case sensitive. So the lowercases can also pass the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know
Signed-off-by: Rui Cao <rcao@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can confirm that the new link works
/skip-all |
Signed-off-by: Rui Cao <rcao@vmware.com>
Update OVS version to 2.13.1
The implementation of the Antrea Proxy(#772 ) depends on this PR.
Signed-off-by: Rui Cao rcao@vmware.com