Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Update OVS version to 2.13.1 #856

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

ruicao93
Copy link
Contributor

@ruicao93 ruicao93 commented Jun 22, 2020

Update OVS version to 2.13.1

The implementation of the Antrea Proxy(#772 ) depends on this PR.

Signed-off-by: Rui Cao rcao@vmware.com

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93 ruicao93 requested a review from antoninbas June 22, 2020 15:30
@ruicao93 ruicao93 added this to the Antrea v0.8.0 release milestone Jun 22, 2020
ruicao93 added a commit to ruicao93/antrea that referenced this pull request Jun 22, 2020
Signed-off-by: Rui Cao <rcao@vmware.com>
@ruicao93
Copy link
Contributor Author

/test-all

@ruicao93 ruicao93 requested a review from wenyingd June 23, 2020 00:33
@ruicao93
Copy link
Contributor Author

/test-conformance

@ruicao93
Copy link
Contributor Author

/test-networkpolicy

$OVSDownloadURL = "http://downloads.antrea.io/ovs/ovs-2.12.90-win64.zip"
$OVSPublishedHash = 'B5278BE3EFFEE322DFB71FABE97B0E4F5C1341CE31D609FD60E8B41D20416C2D'
$OVSDownloadURL = "http://downloads.antrea.io/ovs/ovs-2.13.1-win64.zip"
$OVSPublishedHash = 'bc927e2de8560f2f0d8c2fccd6d69de3d7f4c2c032bf81658d082aa7583b241d'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Get-FileHash returned an hex string with capitalized letters and that we needed to do the same here, or the sanity check below would fail. Is that not the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonin. I update the string to capitalized lettters.

It's interesting that the default compare for string in powershell is not case sensitive. So the lowercases can also pass the check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know

Signed-off-by: Rui Cao <rcao@vmware.com>
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can confirm that the new link works

@ruicao93
Copy link
Contributor Author

/skip-all

@ruicao93 ruicao93 merged commit a37cdbb into antrea-io:master Jun 23, 2020
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
Signed-off-by: Rui Cao <rcao@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants