-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ClickHouse volume ownership #557
Conversation
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
db9ad7f
to
ab5a99b
Compare
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 70.51% 70.56% +0.05%
==========================================
Files 40 40
Lines 5253 5253
==========================================
+ Hits 3704 3707 +3
+ Misses 1372 1370 -2
+ Partials 177 176 -1
*This pull request uses carry forward flags. Click here to find out more. |
Thanks Yanjun for takeing care this. Do you think we will have similar issue for ZooKeeper or Grafana? I couldn't reproduce the issue neither. Not sure what happened. |
ZooKeeper and Grafana should be fine. I remember we have similar work on grafana side for this at theia/build/charts/theia/templates/grafana/deployment.yaml Lines 24 to 30 in 6315647
As for zookeeper, I also find some code here which seems to take care of the folder ownership issue theia/build/charts/theia/templates/clickhouse/zookeeper/statefulset.yaml Lines 135 to 136 in 6315647
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.