Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern #1230

Merged
merged 9 commits into from
Dec 2, 2022
Merged

Fix pattern #1230

merged 9 commits into from
Dec 2, 2022

Conversation

xiaoiver
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@coveralls
Copy link

coveralls commented Nov 30, 2022 •
edited

Pull Request Test Coverage Report for Build 3599792564

  • 26 of 68 (38.24%) changed or added relevant lines in 3 files are covered.
  • 36 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 72.485%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/g-lite/src/plugins/EventPlugin.ts 7 49 14.29%
Files with Coverage Reduction New Missed Lines %
packages/g-lite/src/css/StyleValueRegistry.ts 2 97.79%
packages/g-lite/src/services/TextService.ts 3 76.15%
packages/g-lite/src/plugins/EventPlugin.ts 31 7.64%
Totals Coverage Status
Change from base Build 3529916286: -0.01%
Covered Lines: 5532
Relevant Lines: 7118
💛 - Coveralls

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 1, 2022

This pull request introduces 4 alerts when merging d7af1da into 13b5bf7 - view on LGTM.com

new alerts:

  • 2 for Comparison between inconvertible types
  • 2 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 2, 2022

This pull request introduces 2 alerts when merging 2f2c195 into 13b5bf7 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@xiaoiver
Publish
fd63033 
 - @antv/g-camera-api@1.0.20
 - @antv/g-canvas@1.9.19
 - @antv/g-canvaskit@0.8.19
 - @antv/g-components@1.7.31
 - @antv/g-css-layout-api@1.0.20
 - @antv/g-css-typed-om-api@1.0.20
 - @antv/g-devtool@0.10.31
 - @antv/g-dom-mutation-observer-api@1.0.20
 - @antv/g-gesture@0.0.54
 - @antv/g-image-exporter@0.5.31
 - @antv/g-layout-blocklike@1.7.31
 - @antv/g-lite@1.0.20
 - @antv/g-lottie-player@0.0.17
 - @antv/g-math@1.7.31
 - @antv/g-mobile-canvas-element@0.6.31
 - @antv/g-mobile-canvas@0.8.28
 - @antv/g-mobile-svg@0.8.28
 - @antv/g-mobile-webgl@0.7.34
 - @antv/g-pattern@1.0.1
 - @antv/g-plugin-3d@1.7.31
 - @antv/g-plugin-a11y@0.4.31
 - @antv/g-plugin-annotation@0.2.28
 - @antv/g-plugin-box2d@1.7.31
 - @antv/g-plugin-canvas-path-generator@1.1.31
 - @antv/g-plugin-canvas-picker@1.8.28
 - @antv/g-plugin-canvas-renderer@1.7.34
 - @antv/g-plugin-canvaskit-renderer@1.1.32
 - @antv/g-plugin-control@1.7.31
 - @antv/g-plugin-css-select@1.7.31
 - @antv/g-plugin-device-renderer@1.7.34
 - @antv/g-plugin-dom-interaction@1.7.31
 - @antv/g-plugin-dragndrop@1.6.31
 - @antv/g-plugin-gpgpu@1.7.31
 - @antv/g-plugin-html-renderer@1.7.31
 - @antv/g-plugin-image-loader@1.1.32
 - @antv/g-plugin-matterjs@1.7.31
 - @antv/g-plugin-mobile-interaction@0.7.31
 - @antv/g-plugin-physx@1.7.31
 - @antv/g-plugin-rough-canvas-renderer@1.7.32
 - @antv/g-plugin-rough-svg-renderer@1.7.32
 - @antv/g-plugin-svg-picker@1.7.31
 - @antv/g-plugin-svg-renderer@1.8.28
 - @antv/g-plugin-webgl-device@1.7.31
 - @antv/g-plugin-webgpu-device@1.7.31
 - @antv/g-plugin-yoga@1.7.31
 - @antv/g-shader-components@1.7.31
 - @antv/g-svg@1.8.28
 - @antv/g-web-animations-api@1.0.20
 - @antv/g-web-components@1.7.31
 - @antv/g-webgl@1.7.34
 - @antv/g-webgpu@1.7.34
 - @antv/g@5.15.0
 - @antv/react-g@1.8.28
@xiaoiver xiaoiver merged commit afef664 into next Dec 2, 2022
@xiaoiver xiaoiver deleted the fix-pattern branch December 2, 2022 07:41
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 2, 2022

This pull request introduces 2 alerts when merging fd63033 into 13b5bf7 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@xiaoiver
Copy link
Contributor Author

🎉 This PR is included in version @antv/g-gesture-v2.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor Author

🎉 This PR is included in version @antv/g-gesture-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiaoiver @coveralls