Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release #1432

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Release #1432

merged 3 commits into from
Jul 26, 2023

Conversation

xiaoiver
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

xiaoiver and others added 3 commits July 26, 2023 14:18
@xiaoiver
fix: split a path containing multiple segments into subpaths (#1430)
789bd4c 
* fix: split a path containing multiple segments into subpaths #1429

* chore: commit changeset

* fix: enable FXAA postprocessing pass to apply anti-alias #884

* fix: retrieve runtime from context instead of global
@xiaoiver
chore: commit changeset
70aa0b3
@github-actions
chore(release): bump version (#1431)
7fc2286 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 26, 2023
View reviewed changes
packages/g-plugin-device-renderer/src/renderer/BatchManager.ts
}
}
});
if (existedDrawcall) {

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'existedDrawcall' always evaluates to true.
packages/g-plugin-device-renderer/src/renderer/BatchManager.ts
if (shouldSubmit && existedMesh) {
if (existedMesh.inited && !existedMesh.geometryDirty) {
const shouldMerge = existedMesh.shouldMerge(object, i);
if (existedDrawcall) {

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'existedDrawcall' always evaluates to true.
@xiaoiver xiaoiver merged commit 9529a7e into next Jul 26, 2023
4 of 6 checks passed
@xiaoiver xiaoiver deleted the release branch July 26, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xiaoiver