Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(g-base): add some member functions for Group #262

Merged
merged 1 commit into from
Nov 12, 2019
Merged

feat(g-base): add some member functions for Group #262

merged 1 commit into from
Nov 12, 2019

Conversation

dengfuping
Copy link
Member

πŸ€” This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

πŸ’‘ Background and solution

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English 🌟 [g-canvas] Add some member functions for Group. #260
πŸ‡¨πŸ‡³ Chinese 🌟 [g-canvas] Group δΈŠζ–°ε’žδΈ€δΊ›ζˆε‘˜ζ–Ήζ³•γ€‚#260

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tests-checker[bot]
tests-checker bot suggested changes Nov 10, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 10, 2019 •
edited
Loading

Deploy preview for antv-g ready!

Built with commit db11e89

https://deploy-preview-262--antv-g.netlify.com

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 10, 2019

This pull request fixes 1 alert when merging 5e89eae into 41208eb - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 10, 2019

This pull request fixes 1 alert when merging fdc0ac7 into 41208eb - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 10, 2019

This pull request fixes 1 alert when merging db11e89 into 41208eb - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@dxq613 dxq613 merged commit be0d855 into 4.x Nov 12, 2019
@dxq613 dxq613 deleted the fix-issue-260 branch November 12, 2019 14:02
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dxq613
Merge pull request antvis#262 from antvis/fix-issue-260
56d1cf8 
feat(g-base): add some member functions for Group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@dxq613 dxq613 dxq613 approved these changes

Assignees
No one assigned
Labels
enhancement PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dengfuping @dxq613