Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: line & area #236

Merged
merged 3 commits into from
Nov 15, 2019
Merged

docs: line & area #236

merged 3 commits into from
Nov 15, 2019

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 15, 2019

  • line docs typo
  • area docs typo
  • markdown file path

@auto-add-label auto-add-label bot added the documentation Improvements or additions to documentation label Nov 15, 2019
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -164,12 +164,12 @@ const data = [
`visible: boolean`    图形标签是否显示<br />
`type: 'point' | 'line'`  图形标签类型

<p>(src as img)="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*m9CuRrHRW78AAAAAAAAAAABkARQnAQ" width="600">(/p>
<p><img src="https://gw.alipayobjects.com/mdn/rms_d314dd/afts/img/A*m9CuRrHRW78AAAAAAAAAAABkARQnAQ" width="600"></p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@netlify
Copy link

netlify bot commented Nov 15, 2019

Deploy preview for antv-g2plot ready!

Built with commit 2b32498

https://deploy-preview-236--antv-g2plot.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants